Limit test_hipcub_device_radix_sort memory usage #454
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
|
Could we not implement a run-time check on the current's GPU's total available memory via hipDeviceProp_t instead, and skip the test if the available memory is not sufficient? |
|
We already have a check at and its being used in that test case - so if the test is still executing and failing due to out of memory, we should look into the root cause for that. |
On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. This happens because of an issue that sometimes causes hipMalloc to return hipSuccess for some allocation requests that are too large. This prevents us from being able to reliably detect whether a data size is too large for the test. This change works around the problem for now by limiting the data sizes that used are used for the test.
umfranzw
force-pushed
the
limit_test_radix_sort_mem_usage
branch
from
df2b24c to
1b94b50
Compare
Good idea - I took a closer look at this, and the problem seems to be that in the latest Windows hipSDK build, hipMalloc returns hipSuccess with some sizes that returned hipErrorOutOfMemory in previous hipSDK builds. I'll log a bug with the hipSDK team. We can use this change as a workaround for now if you like. I've added a note about this problem to the "known issues" section of the changelog. |
spolifroni-amd
requested changes
Jan 17, 2025
Co-authored-by: spolifroni-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. Limiting the data sizes that used are used for this test fixes this problem.